Set default signature verification for supported distributions (#1246)

* Default signature verification for supported distributions

* Delegate signature defaults to installers
This commit is contained in:
John
2026-08-24 15:08:03 +01:00
committed by GitHub
parent 1dbac3c9e1
commit b96213d9d2
9 changed files with 82 additions and 19 deletions
@@ -398,13 +398,12 @@ describe('downloadTool', () => {
jest.restoreAllMocks();
});
it('verifies signature when enabled', async () => {
it('verifies signatures by default', async () => {
const signedDistribution = new MicrosoftDistributions({
version: '17',
architecture: 'x64',
packageType: 'jdk',
checkLatest: false,
verifySignature: true
checkLatest: false
});
await signedDistribution['downloadTool']({
@@ -457,14 +457,13 @@ describe('downloadTool', () => {
jest.restoreAllMocks();
});
it('verifies signature when enabled', async () => {
it('verifies signatures by default', async () => {
const distribution = new TemurinDistribution(
{
version: '17',
architecture: 'x64',
packageType: 'jdk',
checkLatest: false,
verifySignature: true
checkLatest: false
},
TemurinImplementation.Hotspot
);
@@ -482,6 +481,27 @@ describe('downloadTool', () => {
);
});
it('does not verify signatures when explicitly disabled', async () => {
const distribution = new TemurinDistribution(
{
version: '17',
architecture: 'x64',
packageType: 'jdk',
checkLatest: false,
verifySignature: false
},
TemurinImplementation.Hotspot
);
await distribution['downloadTool']({
version: '17.0.14+7',
url: 'https://example.com/jdk.tar.gz',
signatureUrl: 'https://example.com/jdk.tar.gz.sig'
});
expect(spyVerifySignature).not.toHaveBeenCalled();
});
it('downloads and adds matching JMODs to the JDK', async () => {
spyDownloadTool
.mockResolvedValueOnce('/tmp/jdk.tar.gz')
@@ -499,7 +519,8 @@ describe('downloadTool', () => {
version: '25',
architecture: 'x64',
packageType: 'jdk+jmods',
checkLatest: false
checkLatest: false,
verifySignature: false
},
TemurinImplementation.Hotspot
);